Add mandalay #24
Merged
Add mandalay #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Python MkII data and SCO FSD data * Corrected speed/boost values to compensate for something coriolis does to the base values, changed pitch/roll/yaw values to match in game (although not fully tested yet) and added bulkhead costs and made up edID's for them since ED doesn't actually have ID's for them in the journal. Also changed the fuelpower value for the SCO 5C FSD to bring range in coriolis closer to what's in game, but 1 of the 3 values is still wrong. This gets worse on the SCO 5A, where all the values go out of whack and changing the fuelpower value does not have the same effect as it does on the 5C SCO. There is further work required here with each SCO FSD to get range to calculate properly. * changing the fuelpower values back to 2.45 in frame_shift_drive.json after some testing. * Removing code already in PR EDCD#98 * Setting EDDBId values to 0 as the ship and these modules do not exist in EDDB
* Add SCO Modules * Correct SCO Rating/Symbol
FDEV Localization Files have a space between Mk and II. To maintain consistency, we should also maintain such a spacing. (See also: Krait Mk II in this repo and the FDEVID repo under EDCD)
…matches in game pricing. OG Python was 1,000cr out, the Mk II was 9Mcr out.
…face (they are in game... should be in Coriolis). This also lead to discovering a bug, where Coriolis generated an inara link that included the planetary approach suite as a module to buy, when the Super Cruise Assist module was fitted... this was simply an incorrect EDDBId on the Super Cruise Assist module and has now been updated to the correct ID. It also raised another bug, where Coriolis would generate the link with the standard Docking Computer in it, no matter which docking computer you actually installed... again, this was an incorrect ID, both computers had the same EDDB Id, this has now been corrected.
The group FSD2 doesn't exist. A typo added it, and freezes Coriolis on selection.
[Fix] SCO 2A Group Fix
…m 1.8km, except the 'enforcer' which has no fall off. As there is no current way to suggest infinity/no fall-off, I have set this to 4.5km, which is its maximum range and therefore, more accurate than infinity anyway. This lines up with Cannon fall-off figures, which are also set to their maximum range, rather than infinity.
…fall_off Adjusted fall-off value for all MC's to 2km where they should be…
…off_fix Changing Enforcer falloff to 3km to match in game metric
…ves unnecessary legacy PAS module from standard modules. Fixes /dist/index.js not being populated properly.
…_to_be_more_graceful Adds dummy modules to facilitate improved import error handling…
…nite_torps_and_enhanced_missile_racks Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo
… make them easier to distinguish in the search results when typing in search words. Also split out advanced missile racks from the missile rack group of hardpoints, to help distinguish them better, as I did with advanced MC's and AX Enhanced MC's and AX Enhanced MRs, etc. This gives sub-categories in the module selection drop down which were not there before.
…_weapons Added 'Special' field to special modules (groms, packhounds, etc.) to…
…odules, including standard, internal and hardpoints. Cross Referenced in-game. This will make pricing in Coriolis in-line with pricing in EDOMH, which is more accurate than Inara, or EDSY. Due to in-game discounts for Triple Elite status, at Jameson in Shin and various other discounts like LYR, pricing in Elite is difficult to keep track of, especially if prices have changed since launch and/or since introduction of a module.
Fixes EDCD/coriolis#780 . I'm not a Node/NPM dev so if this is the Wong Way ™️ I'm open to better suggestions.
…odules, including standard, internal and hardpoints. Cross Referenced in-game. This will make pricing in Coriolis in-line with pricing in EDOMH, which is more accurate than Inara, or EDSY. Due to in-game discounts for Triple Elite status, at Jameson in Shin and various other discounts like LYR, pricing in Elite is difficult to keep track of, especially if prices have changed since launch and/or since introduction of a module.
Fixes EDCD/coriolis#780 . I'm not a Node/NPM dev so if this is the Wong Way ™️ I'm open to better suggestions.
* Pricing update for generally available (not Guardian, trader or PP) modules, including standard, internal and hardpoints. Cross Referenced in-game. This will make pricing in Coriolis in-line with pricing in EDOMH, which is more accurate than Inara, or EDSY. Due to in-game discounts for Triple Elite status, at Jameson in Shin and various other discounts like LYR, pricing in Elite is difficult to keep track of, especially if prices have changed since launch and/or since introduction of a module. * Adding SCO Drive Price update * Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo (#2) * Install uglify-js before use. Fixes EDCD/coriolis#780 . I'm not a Node/NPM dev so if this is the Wong Way ™️ I'm open to better suggestions. * Initial Mandalay commit * Mandalay adjustments * Fixing Mandalay data --------- Co-authored-by: Chris <2653277+chennin@users.noreply.github.com>
* Adds dummy modules to facilitate improved import error handling. Removes unnecessary legacy PAS module from standard modules. Fixes /dist/index.js not being populated properly. (#1) * Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo (#2) * Issue 600 add advanced weapons (#3) * Adds dummy modules to facilitate improved import error handling. Removes unnecessary legacy PAS module from standard modules. Fixes /dist/index.js not being populated properly. * Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo * Added 'Special' field to special modules (groms, packhounds, etc.) to make them easier to distinguish in the search results when typing in search words. Also split out advanced missile racks from the missile rack group of hardpoints, to help distinguish them better, as I did with advanced MC's and AX Enhanced MC's and AX Enhanced MRs, etc. This gives sub-categories in the module selection drop down which were not there before. --------- Co-authored-by: David Sangrey <davidsangrey@gmail.com> * Pricing update for generally available (not Guardian, trader or PP) modules, including standard, internal and hardpoints. Cross Referenced in-game. This will make pricing in Coriolis in-line with pricing in EDOMH, which is more accurate than Inara, or EDSY. Due to in-game discounts for Triple Elite status, at Jameson in Shin and various other discounts like LYR, pricing in Elite is difficult to keep track of, especially if prices have changed since launch and/or since introduction of a module. * Adding SCO Drive Price update * Fix missile rack glitch (#11) * Adds missing missile modifications (#7) * Removing Seeker special from Advanced MR * Install uglify-js before use. Fixes EDCD/coriolis#780 . I'm not a Node/NPM dev so if this is the Wong Way ™️ I'm open to better suggestions. * Type 8 Added to Shipyard (#14) * Initial Addition of the Concord Cannon * Adding EDId of Concord Cannon --------- Co-authored-by: David Sangrey <davidsangrey@gmail.com> Co-authored-by: Chris <2653277+chennin@users.noreply.github.com>
* Adds dummy modules to facilitate improved import error handling. Removes unnecessary legacy PAS module from standard modules. Fixes /dist/index.js not being populated properly. (#1) * Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo (#2) * Issue 600 add advanced weapons (#3) * Adds dummy modules to facilitate improved import error handling. Removes unnecessary legacy PAS module from standard modules. Fixes /dist/index.js not being populated properly. * Adds the Advanced MC's, AX MC's, AX MR's and Nanite Torpedo * Added 'Special' field to special modules (groms, packhounds, etc.) to make them easier to distinguish in the search results when typing in search words. Also split out advanced missile racks from the missile rack group of hardpoints, to help distinguish them better, as I did with advanced MC's and AX Enhanced MC's and AX Enhanced MRs, etc. This gives sub-categories in the module selection drop down which were not there before. --------- Co-authored-by: David Sangrey <davidsangrey@gmail.com> * Pricing update for generally available (not Guardian, trader or PP) modules, including standard, internal and hardpoints. Cross Referenced in-game. This will make pricing in Coriolis in-line with pricing in EDOMH, which is more accurate than Inara, or EDSY. Due to in-game discounts for Triple Elite status, at Jameson in Shin and various other discounts like LYR, pricing in Elite is difficult to keep track of, especially if prices have changed since launch and/or since introduction of a module. * Adding SCO Drive Price update * Fix missile rack glitch (#11) * Adds missing missile modifications (#7) * Removing Seeker special from Advanced MR * Install uglify-js before use. Fixes EDCD/coriolis#780 . I'm not a Node/NPM dev so if this is the Wong Way ™️ I'm open to better suggestions. * Type 8 Added to Shipyard (#14) * Adding boostInt values to ships --------- Co-authored-by: David Sangrey <davidsangrey@gmail.com> Co-authored-by: Chris <2653277+chennin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.