Add Default Message Mapper #3407
Conversation
preardon
requested review from
iancooper,
holytshirt and
DevJonny
as code owners
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
| @@ -379,7 +379,9 @@ public static MessageMapperRegistry MessageMapperRegistry(IServiceProvider provi | |||
|
|
|||
| var messageMapperRegistry = new MessageMapperRegistry( | |||
| new ServiceProviderMapperFactory(provider), | |||
| new ServiceProviderMapperFactoryAsync(provider) | |||
| new ServiceProviderMapperFactoryAsync(provider), | |||
There was a problem hiding this comment.
This may be your comment around async and sync, the fact that we have to register two. The only way around this would be to make all default message mappers implement both. That might be a problem in contexts where it is hard to provide either one of those, due to constraints on libraries used. But it is a little gnarly.
However, we can provide default mappers that implement both
| public Dictionary<Type, Type> Mappers { get; } = new Dictionary<Type, Type>(); | ||
| public Type DefaultMessageMapper { get; private set; } = typeof(JsonMessageMapper<>); |
There was a problem hiding this comment.
Do we need to default the default here, or do we just do that in the extensions DSLs?
|
|
||
| var header = new MessageHeader(messageId: request.Id, topic: publication.Topic, messageType: messageType); | ||
|
|
||
| var body = new MessageBody(JsonSerializer.Serialize(request, JsonSerialisationOptions.Options)); |
There was a problem hiding this comment.
In principle there is an async serializer. I am not sure if it actually has meaning. But we should investigate. The MS route here is to pass an enum flag to the common method and then just use sync or async code in the body, based on that flag as needed
There was a problem hiding this comment.
See the Flag Argument Hack here: https://learn.microsoft.com/en-us/archive/msdn-magazine/2015/july/async-programming-brownfield-async-development
First look into Default Message Mapper
#3355