Updating vdiff goldens for PR 3986 #3987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
ghworkflow/vdiff-pr-3986
branch
from
0e45ede
to
9e92d31
Compare
|
Expected changes:
|
dlockhart
force-pushed
the
US152268_Migrate_calendar_vdiff_tests
branch
from
1df2546
to
fb38fc3
Compare
github-actions
bot
force-pushed
the
ghworkflow/vdiff-pr-3986
branch
from
9e92d31
to
dbfd559
Compare
|
These look good now -- the Arabic golden was incorrect as it was only setting the page language and not the direction previously whereas now the table cells are correctly reversed. |
svanherk
added a commit
that referenced
this pull request
Sep 12, 2023
* US152268 - Migrate calendar vdiff tests * Move existing goldens to new location * Fix the focus effects for disabled dates (other than selected) (#3989) * fix: remove caching of calendar date/time descriptor * Updating vdiff goldens (#3987) Co-authored-by: github-actions <github-actions@github.com> --------- Co-authored-by: Dave Lockhart <dlockhart@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the vdiff goldens for the changes in pull request #3986.
Please review the resulting report closely before merging to ensure the visual differences are expected.