US152268 - Migrate calendar vdiff tests #3986
Conversation
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
dlockhart
force-pushed
the
US152268_Migrate_calendar_vdiff_tests
branch
from
e8b6a65
to
1df2546
Compare
dlockhart
force-pushed
the
US152268_Migrate_calendar_vdiff_tests
branch
from
1df2546
to
fb38fc3
Compare
| } | ||
| function getCalendarData() { | ||
| calendarData = {}; | ||
| calendarData.descriptor = getDateTimeDescriptor(); |
There was a problem hiding this comment.
The culprit was actually two separate places where we were saving local caches -- calendarData here and in getDateTimeDescriptorShared.
Previously the caches were invalidated in calendar's event handler for d2l-localize-resources-change, but because of the isolated fixtures that event fires before any calendars are even put on the page.
I'm going to separately look into adding a cache inside the @brighspace-ui/intl library, since it's in a much better place to invalidate it.
| @@ -139,12 +139,6 @@ export function getDateNoConversion(value) { | |||
| return new Date(parsed.year, parsed.month - 1, parsed.date, parsed.hours, parsed.minutes, parsed.seconds); | |||
| } | |||
|
|
|||
| let dateTimeDescriptor = null; | |||
| export function getDateTimeDescriptorShared(refresh) { | |||
There was a problem hiding this comment.
I just noticed that Nova is using this -- here's the PR to remove it.
Co-authored-by: github-actions <github-actions@github.com>
|
🎉 This PR is included in version 2.146.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Putting this up as a draft PR now, but switching of the language is still broken and needs to be fixed.
Final report: https://vdiff.d2l.dev/BrightspaceUI/core/fb38fc32295b9e57bf0b688111eb22f380269d4e/2023-09-08_17-55-03/report/