Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add d2l-expand-collapse component to create collapsible areas #540
Add d2l-expand-collapse component to create collapsible areas #540
Changes from 9 commits
c7cd86d
fb0dcf8
cd323d0
158b7f8
c67a7cb
330b986
57908c0
8e19258
0c769a0
166bf27
9a1bb36
3ba6ee7
00ae590
0a76373
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that the blue border still appears even when it's collapsed. It makes sense given it's the internal container that gets a
display: none
on it, but as a consumer of this I wouldn't have expected it. I can't think of a super clean way to fix this without reflecting that_state
property up to the host. Hmm...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think having the border still show up will work well. It aligns with FACE's use of expand collapse where they have a line where the expand collapse section is when collapsed. Implementing it like this means it can be done with an attribute selector:
It will also make it a lot easier to use with
d2l-more-less
since that component doesn't fully collapse by default, it leaves 4 ems visibile.