Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add list getSeparator utility #107

Merged
merged 8 commits into from
Jul 5, 2022
Merged

Conversation

eKoopmans
Copy link
Contributor

This PR adds a utility for getting the correct list separator (e.g. ", ") for the current locale. This is required for the new object-property-list component:

To get the object-property-list component to read correctly on screen-readers, we render "hidden commas" between items. For this to work correctly across locales, we need a way to determine the appropriate list separator for the current locale.

Rally: https://rally1.rallydev.com/#/?detail=/userstory/641658870535&fdp=true

lib/list.js Outdated Show resolved Hide resolved
lib/list.js Outdated Show resolved Hide resolved
test/list.js Show resolved Hide resolved
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

README.md Outdated Show resolved Hide resolved
test/index.html Outdated Show resolved Hide resolved
Copy link

@dcostiuc dcostiuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could probably use a review from others.

@eKoopmans eKoopmans merged commit c3fd227 into main Jul 5, 2022
@eKoopmans eKoopmans deleted the ekoopmans/add-get-separator branch July 5, 2022 21:08
@ghost
Copy link

ghost commented Jul 5, 2022

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants