Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add locale names #112

Merged
merged 2 commits into from
Nov 25, 2022
Merged

feat: add locale names #112

merged 2 commits into from
Nov 25, 2022

Conversation

dlockhart
Copy link
Member

@dlockhart dlockhart commented Nov 25, 2022

Exposing the localized locale names for our supported locales. This will make rendering a "language picker" dropdown easier.

Copy link
Contributor

@dbatiste dbatiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. May want to do similar for the culture-specific locales depending on what you decide from this conv: BrightspaceUI/core#3015 (comment)

@dlockhart
Copy link
Member Author

Alright, I've switched this to expose details about the culture-specific locales instead. I don't see a need to expose both -- we can always add it later if it's needed.

@dlockhart dlockhart changed the title feat: add base locale names feat: add locale names Nov 25, 2022
@dlockhart dlockhart merged commit ea5dd5c into main Nov 25, 2022
@dlockhart dlockhart deleted the dlockhart/add-locale-names branch November 25, 2022 18:28
@ghost
Copy link

ghost commented Nov 25, 2022

🎉 This PR is included in version 3.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants