Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to package.json #131

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add type to package.json #131

merged 1 commit into from
Oct 30, 2023

Conversation

bearfriend
Copy link
Contributor

There are some edge cases where imports from this library fail because it thinks it's a commonJS module. Frankly, I'm not sure why there hasn't been more issues without this declared.

@bearfriend bearfriend requested a review from a team as a code owner October 30, 2023 16:25
Copy link
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed!

@bearfriend bearfriend merged commit b918f24 into main Oct 30, 2023
1 check passed
@bearfriend bearfriend deleted the dgleckler/type-module branch October 30, 2023 16:31
@ghost
Copy link

ghost commented Oct 30, 2023

🎉 This PR is included in version 3.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants