feat: Add allow-overflow to navigation-immersive #213
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| allowOverflow: { | ||
| type: Boolean, | ||
| reflectToAttribute: true | ||
| }, |
There was a problem hiding this comment.
@dbatiste is working on some changes to how our dropdowns work... not sure if it might actually solve this?
There was a problem hiding this comment.
Ooh exciting, popup API stuff?
There was a problem hiding this comment.
Dave, does it make sense to add a story/task to your stuff to circle back to this change when everything is finished and undo it?
There was a problem hiding this comment.
Yeah I noticed it was from the original PR that added navigation-immersive, not sure what the motivation was for the overflow specifically. The regular (non-immersive) navigation allows overflow, which is how things like this work:
There was a problem hiding this comment.
@dlockhart , Yeah I think so.
I suspect this is to handle this case. But perhaps not just that case.
There was a problem hiding this comment.
Yeah, I remember we ran into this issue pretty much immediately, when we implemented the dropdowns and added them to the main nav. I recall having to find a way to avoid the overflow.
There was a problem hiding this comment.
Just confirmed that we're already separately handling the overflow from Dave's screenshot, glad you called it out though:
There was a problem hiding this comment.
Ooh exciting, popup API stuff?
Eventually, hopefully/yes. But initially, it will just be adapting the existing positioning code to unblock some other things.
|
Thanks for the speedy review Daves! |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
We're adding a dropdown to our folio immersive-nav-bar, and the
overflow: hiddenwas causing issues. I don't know if any consumers rely on the overflow being hidden, so I added a new attribute to disable it.Here's what the demo looks like without
allow-overflow:And with:
https://desire2learn.atlassian.net/browse/VOY-2250