Fix initialization issue #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorge-ramirez-arredondo
force-pushed
the
jorge-ramirez-arredondo/FixInitializationIssue
branch
from
cff9bd1
to
047ef82
Compare
jorge-ramirez-arredondo
changed the title
jorge-ramirez-arredondo
force-pushed
the
jorge-ramirez-arredondo/FixInitializationIssue
branch
from
3955424
to
f69af5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue where the
RouteReactorwas not initializing its context values until after the first update. I couldn't figure out an easy way to fix it so I ended up changing how the ContextReactor listens for route changes.Note: This change also fixes the Route order inversion issue in a more natural way. As a result, in order to maintain the opt-in nature of the fix, I had to simulate the issue by manually reversing the route definitions if the
enableRouteOrderFixoption isn't set. This technically isn't the exact same issue, but it should simulate the issue well enough that there's time to fix current implementations with the known workaround.