Skip to content

Commit

Permalink
Amplitude tweaks (#310)
Browse files Browse the repository at this point in the history 
* Change amplitude project keys.
* Initialize amplitude only once in `amplitude.js`.
* Upgrade Handlebars to fix security issue:
handlebars-lang/handlebars.js#1495
  • Loading branch information
@ghinda
ghinda authored Jun 28, 2019
1 parent 15b3df0 commit 89069ab
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 67 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gorgias",
"version": "6.1.2",
"version": "6.1.3",
"description": "Gorgias grunt package",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -74,7 +74,7 @@
"csvexport": "^1.0.5",
"font-awesome": "FortAwesome/Font-Awesome#4.5.0",
"fuse.js": "krisk/Fuse#~2.2.0",
"handlebars": "4.0.4",
"handlebars": "^4.0.14",
"jquery": "jquery/jquery-dist#2.1.4",
"js-md5": "emn178/js-md5#~0.3.0",
"microplugin": "brianreavis/microplugin.js#0.0.x",
Expand Down
10 changes: 0 additions & 10 deletions src/background/js/app.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,16 +147,6 @@ gApp.run(function ($rootScope, $location, $http, $timeout, ProfileService, Setti
$rootScope.showStats = true;

SettingsService.get('settings').then(function (settings) {
if (ENV && ENV === 'production') {
amplitude.getInstance().init("e50d000bcba1aa363cd1f71642ed466a", {
saveEvents: false // don't store in localStorage the events - it slows down everything
});
} else if (ENV && ENV === 'development') {
amplitude.getInstance().init("a31babba9c8dedf2334c44d8acdad247", {
saveEvents: false // don't store in localStorage the events - it slows down everything
});
}

// Make sure that we have all the defaults
SettingsService.set('settings', _.defaults(settings, Settings.defaults.settings));

Expand Down
9 changes: 8 additions & 1 deletion src/background/js/utils/amplitude.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,4 +59,11 @@
e.amplitude = n;
})(window, document);

amplitude.getInstance().init("a31babba9c8dedf2334c44d8acdad247");
var amplitudeKey = '1294f53908a5dbc50b8e14f25c272c81';
if (ENV && ENV === 'production') {
amplitudeKey = '2ed48634e41364b798b6f11df0cbe59a';
}

amplitude.getInstance().init(amplitudeKey, {
saveEvents: false // don't store in localStorage the events - it slows down everything
});
2 changes: 1 addition & 1 deletion src/manifest.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"manifest_version": 2,
"name": "__MSG_extName__",
"version": "6.1.2",
"version": "6.1.3",
"description": "__MSG_extDesc__",
"short_name": "Gorgias",
"default_locale": "en",
Expand Down
79 changes: 26 additions & 53 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ async-each@^1.0.0:
resolved "https://registry.yarnpkg.com/async-each/-/async-each-1.0.1.tgz#19d386a1d9edc6e7c1c85d388aedbcc56d33602d"
integrity sha1-GdOGodntxufByF04iu28xW0zYC0=

async@^1.4.0, async@^1.5.0, async@^1.5.2:
async@^1.5.0, async@^1.5.2:
version "1.5.2"
resolved "https://registry.yarnpkg.com/async/-/async-1.5.2.tgz#ec6a61ae56480c0c3cb241c95618e20892f9672a"

Expand All @@ -588,7 +588,7 @@ async@~0.1.22:
version "0.1.22"
resolved "https://registry.yarnpkg.com/async/-/async-0.1.22.tgz#0fc1aaa088a0e3ef0ebe2d8831bab0dcf8845061"

async@~0.2.6, async@~0.2.9:
async@~0.2.9:
version "0.2.10"
resolved "https://registry.yarnpkg.com/async/-/async-0.2.10.tgz#b6bbe0b0674b9d719708ca38de8c237cb526c3d1"

Expand Down Expand Up @@ -1615,10 +1615,6 @@ camelcase-keys@^2.0.0:
camelcase "^2.0.0"
map-obj "^1.0.0"

camelcase@^1.0.2:
version "1.2.1"
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-1.2.1.tgz#9bb5304d2e0b56698b2c758b08a3eaa9daa58a39"

camelcase@^2.0.0:
version "2.1.1"
resolved "https://registry.yarnpkg.com/camelcase/-/camelcase-2.1.1.tgz#7c1d16d679a1bbe59ca02cacecfb011e201f5a1f"
Expand Down Expand Up @@ -2026,6 +2022,11 @@ commander@~2.17.1:
resolved "https://registry.yarnpkg.com/commander/-/commander-2.17.1.tgz#bd77ab7de6de94205ceacc72f1716d29f20a77bf"
integrity sha512-wPMUt6FnH2yzG95SA6mzjQOEKUU3aLaDEmzs1ti+1E9h+CsrZghRlqEM/EJ4KscsQVG8uNN4uVreUeT8+drlgg==

commander@~2.20.0:
version "2.20.0"
resolved "https://registry.yarnpkg.com/commander/-/commander-2.20.0.tgz#d58bb2b5c1ee8f87b0d340027e9e94e222c5a422"
integrity sha512-7j2y+40w61zy6YC2iRNpUe/NwhNyoXrYpHMrSunaMG64nRnaf96zO/KMQR4OyN/UnE5KLyEBnKHd4aG3rskjpQ==

commondir@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/commondir/-/commondir-1.0.1.tgz#ddd800da0c66127393cca5950ea968a3aaf1253b"
Expand Down Expand Up @@ -2477,7 +2478,7 @@ debuglog@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/debuglog/-/debuglog-1.0.1.tgz#aa24ffb9ac3df9a2351837cfb2d279360cd78492"

decamelize@^1.0.0, decamelize@^1.1.1, decamelize@^1.1.2:
decamelize@^1.1.1, decamelize@^1.1.2:
version "1.2.0"
resolved "https://registry.yarnpkg.com/decamelize/-/decamelize-1.2.0.tgz#f6534d15148269b20352e7bee26f501f9a191290"

Expand Down Expand Up @@ -3889,15 +3890,16 @@ handle-thing@^1.2.5:
version "1.2.5"
resolved "https://registry.yarnpkg.com/handle-thing/-/handle-thing-1.2.5.tgz#fd7aad726bf1a5fd16dfc29b2f7a6601d27139c4"

handlebars@4.0.4:
version "4.0.4"
resolved "https://registry.yarnpkg.com/handlebars/-/handlebars-4.0.4.tgz#12b94e9c4cafa612424b1c13addf612c0d2a5f29"
handlebars@^4.0.14:
version "4.1.2"
resolved "https://registry.yarnpkg.com/handlebars/-/handlebars-4.1.2.tgz#b6b37c1ced0306b221e094fc7aca3ec23b131b67"
integrity sha512-nvfrjqvt9xQ8Z/w0ijewdD/vvWDTOweBUm96NTr66Wfvo1mJenBLwcYmPs3TIBP5ruzYGD7Hx/DaM9RmhroGPw==
dependencies:
async "^1.4.0"
neo-async "^2.6.0"
optimist "^0.6.1"
source-map "^0.4.4"
source-map "^0.6.1"
optionalDependencies:
uglify-js "~2.4"
uglify-js "^3.1.4"

har-schema@^2.0.0:
version "2.0.0"
Expand Down Expand Up @@ -5788,6 +5790,11 @@ neo-async@^2.5.0:
resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.0.tgz#b9d15e4d71c6762908654b5183ed38b753340835"
integrity sha512-MFh0d/Wa7vkKO3Y3LlacqAEeHK0mckVqzDieUKTT+KGxi+zIpeVsFxymkIiRpbpDziHc290Xr9A1O4Om7otoRA==

neo-async@^2.6.0:
version "2.6.1"
resolved "https://registry.yarnpkg.com/neo-async/-/neo-async-2.6.1.tgz#ac27ada66167fa8849a6addd837f6b189ad2081c"
integrity sha512-iyam8fBuCUpWeKPGpaNMetEocMt364qkCsfL9JuhjXX6dRnguRVOfk2GZaDpPjcOKiiXCPINZC1GczQ7iTq3Zw==

ng-file-upload@danialfarid/angular-file-upload-bower#~11.0.2:
version "0.0.0"
resolved "https://codeload.github.com/danialfarid/angular-file-upload-bower/tar.gz/e4cff1c8a50439ba0770c30874059a024bd3eff2"
Expand Down Expand Up @@ -8215,12 +8222,6 @@ source-map@0.1.32:
dependencies:
amdefine ">=0.0.4"

source-map@0.1.34:
version "0.1.34"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.1.34.tgz#a7cfe89aec7b1682c3b198d0acfb47d7d090566b"
dependencies:
amdefine ">=0.0.4"

source-map@0.1.x:
version "0.1.43"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.1.43.tgz#c24bc146ca517c1471f5dacbe2571b2b7f9e3346"
Expand All @@ -8237,12 +8238,6 @@ source-map@^0.3.0:
dependencies:
amdefine ">=0.0.4"

source-map@^0.4.4:
version "0.4.4"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.4.4.tgz#eba4f5da9c0dc999de68032d8b4f76173652036b"
dependencies:
amdefine ">=0.0.4"

source-map@^0.6.0, source-map@^0.6.1, source-map@~0.6.1:
version "0.6.1"
resolved "https://registry.yarnpkg.com/source-map/-/source-map-0.6.1.tgz#74722af32e9614e9c287a8d0bbde48b5e2f1a263"
Expand Down Expand Up @@ -8867,18 +8862,13 @@ uglify-js@3.3.x:
commander "~2.15.0"
source-map "~0.6.1"

uglify-js@~2.4:
version "2.4.24"
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.4.24.tgz#fad5755c1e1577658bb06ff9ab6e548c95bebd6e"
uglify-js@^3.1.4:
version "3.6.0"
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-3.6.0.tgz#704681345c53a8b2079fb6cec294b05ead242ff5"
integrity sha512-W+jrUHJr3DXKhrsS7NUVxn3zqMOFn0hL/Ei6v0anCIMoKC93TjcflTagwIHLW7SfMFfiQuktQyFVCFHGUE0+yg==
dependencies:
async "~0.2.6"
source-map "0.1.34"
uglify-to-browserify "~1.0.0"
yargs "~3.5.4"

uglify-to-browserify@~1.0.0:
version "1.0.2"
resolved "https://registry.yarnpkg.com/uglify-to-browserify/-/uglify-to-browserify-1.0.2.tgz#6e0924d6bda6b5afe349e39a6d632850a0f882b7"
commander "~2.20.0"
source-map "~0.6.1"

uid-number@0.0.6:
version "0.0.6"
Expand Down Expand Up @@ -9441,14 +9431,6 @@ widest-line@^2.0.0:
dependencies:
string-width "^2.1.1"

window-size@0.1.0:
version "0.1.0"
resolved "https://registry.yarnpkg.com/window-size/-/window-size-0.1.0.tgz#5438cd2ea93b202efa3a19fe8887aee7c94f9c9d"

wordwrap@0.0.2:
version "0.0.2"
resolved "https://registry.yarnpkg.com/wordwrap/-/wordwrap-0.0.2.tgz#b79669bb42ecb409f83d583cad52ca17eaa1643f"

wordwrap@~0.0.2:
version "0.0.3"
resolved "https://registry.yarnpkg.com/wordwrap/-/wordwrap-0.0.3.tgz#a3d5da6cd5c0bc0008d37234bbaf1bed63059107"
Expand Down Expand Up @@ -9603,15 +9585,6 @@ yargs@~1.2.6:
dependencies:
minimist "^0.1.0"

yargs@~3.5.4:
version "3.5.4"
resolved "https://registry.yarnpkg.com/yargs/-/yargs-3.5.4.tgz#d8aff8f665e94c34bd259bdebd1bfaf0ddd35361"
dependencies:
camelcase "^1.0.2"
decamelize "^1.0.0"
window-size "0.1.0"
wordwrap "0.0.2"

yazl@^2.4.3:
version "2.4.3"
resolved "https://registry.yarnpkg.com/yazl/-/yazl-2.4.3.tgz#ec26e5cc87d5601b9df8432dbdd3cd2e5173a071"
Expand Down

0 comments on commit 89069ab

Please sign in to comment.