Min macos version

Brooooooklyn · Feb 5, 2024 · 08f8811 · 08f8811 · github-actions · Feb 5, 2024
1 parent 5f1f03d
commit 08f8811
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/CI.yaml b/.github/workflows/CI.yaml
@@ -63,6 +63,7 @@ jobs:
               export CXX=$(xcrun -f clang++);
               SYSROOT=$(xcrun --sdk macosx --show-sdk-path);
               export CFLAGS="-isysroot $SYSROOT -isystem $SYSROOT";
+              export MACOSX_DEPLOYMENT_TARGET='11.0'
               yarn build --target aarch64-apple-darwin
               strip -x skia.darwin-arm64.node
           - host: ubuntu-latest

diff --git a/.github/workflows/skia.yaml b/.github/workflows/skia.yaml
@@ -132,6 +132,8 @@ jobs:
 
       - name: Compile skia
         run: node ./scripts/build-skia.js --target=aarch64-apple-darwin
+        env:
+          MACOSX_DEPLOYMENT_TARGET: '11.0'
 
       - name: Install dependencies
         run: yarn install --immutable --mode=skip-build

diff --git a/scripts/build-skia.js b/scripts/build-skia.js
@@ -198,9 +198,9 @@ switch (TARGET_TRIPLE) {
   case 'aarch64-apple-darwin':
     ExtraSkiaBuildFlag += ' target_cpu="arm64" target_os="mac"'
     ExtraCflagsCC += ', "--target=arm64-apple-macos", "-mmacosx-version-min=11.0"'
-    ExtraLdFlags = '"--target=arm64-apple-macos"'
-    ExtraAsmFlags = '"--target=arm64-apple-macos"'
-    ExtraCflags = '"--target=arm64-apple-macos"'
+    ExtraLdFlags = '"--target=arm64-apple-macos", "-mmacosx-version-min=11.0"'
+    ExtraAsmFlags = '"--target=arm64-apple-macos", "-mmacosx-version-min=11.0"'
+    ExtraCflags = '"--target=arm64-apple-macos", "-mmacosx-version-min=11.0"'
     GN_ARGS.push(
       `extra_ldflags=[${ExtraLdFlags}]`,
       `extra_asmflags=[${ExtraAsmFlags}]`,
Benchmark suite	Current: `08f8811`	Previous: `c0be5da`	Ratio
`Draw house#skia-canvas`	`29.5` ops/sec (`±0.67%`)	`29.51` ops/sec (`±0.36%`)	`1.00`
`Draw house#node-canvas`	`37.6` ops/sec (`±0.55%`)	`37.26` ops/sec (`±0.59%`)	`0.99`
`Draw house#@napi-rs/skia`	`29.7` ops/sec (`±0.39%`)	`29.52` ops/sec (`±0.8%`)	`0.99`
`Draw gradient#skia-canvas`	`28` ops/sec (`±0.26%`)	`28.5` ops/sec (`±0.25%`)	`1.02`
`Draw gradient#node-canvas`	`37` ops/sec (`±0.5%`)	`36.3` ops/sec (`±0.53%`)	`0.98`
`Draw gradient#@napi-rs/skia`	`29` ops/sec (`±0.75%`)	`28.3` ops/sec (`±0.64%`)	`0.98`