loadImage() does not handle exceptions properly, causing calling code to crash ("floating" async code)

[lostfictions]

Hi, thanks for your work on this library!

I've been hitting an odd issue occasionally and it took me a while to diagnose. I have some code that looks like this...

try {
  const image = await loadImage(someUrl);
  // do some other things, call `ctx.drawImage()`, etc...
} catch (error) {
  console.error(error);
  // contextually handle the error...
}

However, occasionally this would cause errors that would "escape" the try-catch block, crashing the program. Something like this:

TypeError: Invalid URL
    at new URL (node:internal/url:797:36)
    at ClientRequest.<anonymous> (/[project folder]/node_modules/.pnpm/@napi-rs+canvas@0.1.44/node_modules/@napi-rs/canvas/load-image.js:68:30)
    at Object.onceWrapper (node:events:634:26)
    at ClientRequest.emit (node:events:519:28)
    at ClientRequest.emit (node:domain:488:12)
    at HTTPParser.parserOnIncomingClient [as onIncoming] (node:_http_client:698:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:119:17)
    at TLSSocket.socketOnData (node:_http_client:540:22)
    at TLSSocket.emit (node:events:519:28)
    at TLSSocket.emit (node:domain:488:12) {
  code: 'ERR_INVALID_URL',
  input: '/Images/somepicture.png'
}

I think there's two parts to this problem:

First, the reason this specific error arises is that sometimes redirects are relative and don't contain the full URL origin. So https://something.com/mypic.png might have a redirect to /pictures/mypic.png, which should be interpreted as https://something.com/pictures/mypic.png. But makeRequest() is constructing URLs without passing the base parameter, causing any relative redirects to throw an error on this line:

canvas/load-image.js

Line 66 in df9a942

return makeRequest(new URL(res.headers.location), resolve, reject, redirectCount - 1, requestOptions)

However, there's also a second, broader problem: this error can't be caught by user code! It's located within a callback, and fails to catch the error and pass it to the reject() handler that makeRequest() receives. (In other words, it's sort of like a "floating promise", which is why none of the user's files appear within the stack trace above.)

There may be more types of errors within this kind of code that would similarly escape try...catch blocks (or Promise .catch() handlers) as well; I think the solution here is to add try...catch blocks in makeRequest().