Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add setting to switch between viewport logic #211

Closed
wants to merge 2 commits into from
Closed

ENH: Add setting to switch between viewport logic #211

wants to merge 2 commits into from

Conversation

NicerNewerCar
Copy link
Contributor

@NicerNewerCar NicerNewerCar commented Oct 18, 2023 •
edited
Loading

@jcfr
Copy link
Contributor

jcfr commented Oct 19, 2023

Before we integrate this one, could you create independent PRs for:

  • only reverting how render_height and render_width are computed. This will allows @amymmorton to move forward with the agreement and performance tests.
  • only adding the docstrings

NicerNewerCar added a commit to NicerNewerCar/Autoscoper that referenced this pull request Oct 19, 2023
@NicerNewerCar
PERF: Switch back to original viewport conversion
c04864b 
* Switch back to the original conversion from viewport to pixel.
* The method integrated in PR BrownBiomechanics#204 causes a performace slow down because
  of the larger images generated.
* A follow-up PR, BrownBiomechanics#211 will be integrated to allow for the option of
  using the newer method
@NicerNewerCar NicerNewerCar mentioned this pull request Oct 19, 2023
Merged
@NicerNewerCar
Copy link
Contributor Author

NicerNewerCar commented Oct 19, 2023 •
edited
Loading

Before we integrate this one, could you create independent PRs for:

  • only reverting how render_height and render_width are computed. This will allows @amymmorton to move forward with the agreement and performance tests.
  • only adding the docstrings

See:

Once the above two PRs are integrated we can rebase this branch

@amymmorton
Copy link
Collaborator

I need to test the proposed alternate more .. a modified aspect ratio still doesn't sit right with me. Reverting back to pre 204 is a good move. - SLow down still not fully attributed to this issue

amymmorton
amymmorton requested changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See:

#203 (comment)

@jcfr
Copy link
Contributor

jcfr commented Oct 20, 2023

Reverting back to pre 204 is a good move

For reference:

@jcfr
Copy link
Contributor

jcfr commented Oct 20, 2023 •
edited
Loading

For convenience, I re-based against the latest main and removed the introduction of comment now being integrated through #213

@NicerNewerCar NicerNewerCar mentioned this pull request Nov 8, 2023
Merged
@jcfr jcfr closed this in #230 Nov 16, 2023
@NicerNewerCar NicerNewerCar deleted the render-res-calc branch February 21, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amymmorton amymmorton amymmorton requested changes

@jcfr jcfr Awaiting requested review from jcfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicerNewerCar @jcfr @amymmorton