Fix "https.passphrase" option being discarded #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serverUtils.getHttpsOptions() was ignoring the `https.passphrase` options since the "default" https options were merged on top of user options. Another solution to this is to just omit the `passphrase` key entirely in the defaults section, but I took this approach in order to preserve the current behavior where it's set to an empty string by default.
shakyShane
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serverUtils.getHttpsOptions() was ignoring the
https.passphraseoption since the "default" https options were merged on top of user options, blowing away the passphrase.Another solution to this is to simply omit the
passphrasekey entirely in the defaults section, but I took this approach in order to preserve the current behavior where it's set to an empty string by default.