-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove localtunnel #2059
remove localtunnel #2059
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
FYI changes to dependencies and semver is a hotly debated topic but for a security fix like this, imho it would have been nicer to release it within the same major version since now other packages need to be updated to allow the new major version first. |
@lsmith77 - thanks. Yeah I did consider that. Honestly I'd be happy to release this same tag into 2.x too (to increase adoption) - it's just hard to judge if it's impacting anyone or not (since Browsersync has both a giant user base + zero telemetry) |
angular users would appreciate a release since there is not yet a release of a browsersync 3.0 compatible version |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [browser-sync](https://browsersync.io/) ([source](https://togithub.com/BrowserSync/browser-sync)) | [`2.29.3` -> `3.0.2`](https://renovatebot.com/diffs/npm/browser-sync/2.29.3/3.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BrowserSync/browser-sync (browser-sync)</summary> ### [`v3.0.2`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.2) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.1...v3.0.2) #### What's Changed - fix: dist path by [@​bufo24](https://togithub.com/bufo24) in [https://github.com/BrowserSync/browser-sync/pull/2054](https://togithub.com/BrowserSync/browser-sync/pull/2054) - fix ui-external url by [@​qdirks](https://togithub.com/qdirks) in [https://github.com/BrowserSync/browser-sync/pull/1970](https://togithub.com/BrowserSync/browser-sync/pull/1970) #### New Contributors - [@​bufo24](https://togithub.com/bufo24) made their first contribution in [https://github.com/BrowserSync/browser-sync/pull/2054](https://togithub.com/BrowserSync/browser-sync/pull/2054) - [@​qdirks](https://togithub.com/qdirks) made their first contribution in [https://github.com/BrowserSync/browser-sync/pull/1970](https://togithub.com/BrowserSync/browser-sync/pull/1970) **Full Changelog**: BrowserSync/browser-sync@v3.0.1...v3.0.2 ### [`v3.0.1`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.1) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.0...v3.0.1) ####⚠️ Breaking - removed localtunnel (it's not maintained, and was always optional) - see [https://github.com/BrowserSync/browser-sync/pull/2059](https://togithub.com/BrowserSync/browser-sync/pull/2059) #### What's Changed - build(deps): bump nanoid and mocha in /packages/browser-sync-ui by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2015](https://togithub.com/BrowserSync/browser-sync/pull/2015) - build(deps): bump engine.io from 6.2.1 to 6.4.2 in /packages/browser-sync by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2038](https://togithub.com/BrowserSync/browser-sync/pull/2038) - build(deps-dev): bump webpack from 5.75.0 to 5.76.0 in /packages/browser-sync-client by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2027](https://togithub.com/BrowserSync/browser-sync/pull/2027) - build(deps): bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2014](https://togithub.com/BrowserSync/browser-sync/pull/2014) - build(deps): bump json-schema and jsprim in /packages/browser-sync-ui by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2042](https://togithub.com/BrowserSync/browser-sync/pull/2042) - fixing nx caching, run tests on nonde 16, 18 & 20 by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2050](https://togithub.com/BrowserSync/browser-sync/pull/2050) - Update README.md by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2051](https://togithub.com/BrowserSync/browser-sync/pull/2051) - adding playwright tests by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2052](https://togithub.com/BrowserSync/browser-sync/pull/2052) - remove localtunnel by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2059](https://togithub.com/BrowserSync/browser-sync/pull/2059) **Full Changelog**: BrowserSync/browser-sync@v2.29.3...v3.0.1 ### [`v3.0.0`](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/MISW/works-misw-jp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [browser-sync](https://browsersync.io/) ([source](https://togithub.com/BrowserSync/browser-sync)) | [`2.29.3` -> `3.0.2`](https://renovatebot.com/diffs/npm/browser-sync/2.29.3/3.0.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/browser-sync/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/browser-sync/2.29.3/3.0.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>BrowserSync/browser-sync (browser-sync)</summary> ### [`v3.0.2`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.2) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.1...v3.0.2) #### What's Changed - fix: dist path by [@​bufo24](https://togithub.com/bufo24) in [https://github.com/BrowserSync/browser-sync/pull/2054](https://togithub.com/BrowserSync/browser-sync/pull/2054) - fix ui-external url by [@​qdirks](https://togithub.com/qdirks) in [https://github.com/BrowserSync/browser-sync/pull/1970](https://togithub.com/BrowserSync/browser-sync/pull/1970) #### New Contributors - [@​bufo24](https://togithub.com/bufo24) made their first contribution in [https://github.com/BrowserSync/browser-sync/pull/2054](https://togithub.com/BrowserSync/browser-sync/pull/2054) - [@​qdirks](https://togithub.com/qdirks) made their first contribution in [https://github.com/BrowserSync/browser-sync/pull/1970](https://togithub.com/BrowserSync/browser-sync/pull/1970) **Full Changelog**: BrowserSync/browser-sync@v3.0.1...v3.0.2 ### [`v3.0.1`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v3.0.1) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v3.0.0...v3.0.1) ####⚠️ Breaking - removed localtunnel (it's not maintained, and was always optional) - see [https://github.com/BrowserSync/browser-sync/pull/2059](https://togithub.com/BrowserSync/browser-sync/pull/2059) #### What's Changed - build(deps): bump nanoid and mocha in /packages/browser-sync-ui by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2015](https://togithub.com/BrowserSync/browser-sync/pull/2015) - build(deps): bump engine.io from 6.2.1 to 6.4.2 in /packages/browser-sync by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2038](https://togithub.com/BrowserSync/browser-sync/pull/2038) - build(deps-dev): bump webpack from 5.75.0 to 5.76.0 in /packages/browser-sync-client by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2027](https://togithub.com/BrowserSync/browser-sync/pull/2027) - build(deps): bump json5 from 1.0.1 to 1.0.2 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2014](https://togithub.com/BrowserSync/browser-sync/pull/2014) - build(deps): bump json-schema and jsprim in /packages/browser-sync-ui by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/BrowserSync/browser-sync/pull/2042](https://togithub.com/BrowserSync/browser-sync/pull/2042) - fixing nx caching, run tests on nonde 16, 18 & 20 by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2050](https://togithub.com/BrowserSync/browser-sync/pull/2050) - Update README.md by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2051](https://togithub.com/BrowserSync/browser-sync/pull/2051) - adding playwright tests by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2052](https://togithub.com/BrowserSync/browser-sync/pull/2052) - remove localtunnel by [@​shakyShane](https://togithub.com/shakyShane) in [https://github.com/BrowserSync/browser-sync/pull/2059](https://togithub.com/BrowserSync/browser-sync/pull/2059) **Full Changelog**: BrowserSync/browser-sync@v2.29.3...v3.0.1 ### [`v3.0.0`](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0) [Compare Source](https://togithub.com/BrowserSync/browser-sync/compare/v2.29.3...v3.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/MISW/misw-jp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
it was always an optional code-path, so now anyone wanting to use localtunnel can continue to do so, after installing it themselves.