WebNN binary tests #110
WebNN binary tests #110
Conversation
| @@ -0,0 +1,133 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
Please document the tfjs source and its Apache2 license in that file (in addition to the readme)
webnn/resources/README.md
Outdated
| @@ -0,0 +1,7 @@ | |||
| There are those following functions in ./utils.js copyed from | |||
There was a problem hiding this comment.
| There are those following functions in ./utils.js copyed from | |
| There are those following functions in ./utils.js copied from |
webnn/resources/README.md
Outdated
| getBroadcastDims() | ||
| assertAndGetBroadcastShape() | ||
| locToIndex() | ||
| indexToLoc() |
There was a problem hiding this comment.
please mention the tfjs license here https://github.com/tensorflow/tfjs/blob/master/LICENSE
webnn/binary.html
Outdated
| ]; | ||
|
|
||
| // get baseline | ||
| const expected = baseline.binary( |
There was a problem hiding this comment.
as I alluded in webmachinelearning/webnn-polyfill#144 (comment), I wonder if it would not be better to provided hardcoded expected values rather than have them be calculated each time by the device under test (e.g. to avoid the case where the CPU or the JS engine itself are faulty). I'm not sure how likely that would be, so maybe this is not a high-priority concern.
|
Thanks much @dontcallmedom. I will address your comments, and update this PR. |
| @@ -1,5 +1,21 @@ | |||
| /** | |||
| * Copyright 2021 WebNN Tests contributors | |||
There was a problem hiding this comment.
From https://github.com/tensorflow/tfjs/blob/master/tfjs-core/src/ops/broadcast_util.ts#L3
Copyright 2017 Google LLC. All Rights Reserved.
, I'm not sure that it's allowable to use the code of tensorflow/tfjs project. Any comment, thanks.
There was a problem hiding this comment.
Since the files we're copying ares under Apache 2 license, as long as we keep the licensing info intact, there should be no issue with copying the code. But the copyright needs to remain to Google LLC (here and in all the other copied files)
| @@ -1,5 +1,21 @@ | |||
| /** | |||
| * Copyright 2021 WebNN Tests contributors | |||
There was a problem hiding this comment.
Since the files we're copying ares under Apache 2 license, as long as we keep the licensing info intact, there should be no issue with copying the code. But the copyright needs to remain to Google LLC (here and in all the other copied files)
| @@ -0,0 +1,8 @@ | |||
| There are those following functions in ./utils.js copied from | |||
| https://github.com/tensorflow/tfjs project which is licensed under the [LICENSE](https://github.com/tensorflow/tfjs/blob/master/LICENSE). | |||
There was a problem hiding this comment.
| https://github.com/tensorflow/tfjs project which is licensed under the [LICENSE](https://github.com/tensorflow/tfjs/blob/master/LICENSE). | |
| https://github.com/tensorflow/tfjs project which is licensed under the [Apache 2.0 License](https://github.com/tensorflow/tfjs/blob/master/LICENSE). |
|
We've started a new baseline implementation from scratch without referring 3rd party libraries. https://github.com/huningxin/webnn-baseline I propose to move it to group repo for wider review and development: webmachinelearning/webnn#245 |
No description provided.