-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
BadUSB/BLE Updates #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emericklaw
wants to merge
25
commits into
BruceDevices:dev
Choose a base branch
from
emericklaw:badusbble
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BadUSB/BLE Updates #1997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…due to the delay being too low for HID to handle
Member
Author
|
Fixed merge conflicts after presenter was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
BadUSB/BLE
ALTCHAR 65will outputAOther Minor Changes
Types of Changes
Enhancement
Verification
Current - 6.7 seconds
This Change - 2 seconds
New Screen

Testing
I have tested on a few Bruce devices with no issues.
BadBLE was also tested, only issue is missing keystrokes if the connected device cannot keep up, there is a warning shown when launching BadBLE if the delay is lower than 50ms.
I have not tested using a CH9329, it should work.
Linked Issues
Fixes #1157
User-Facing Change
Further Comments