Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large .geogram files #223

Closed
8 tasks done
BrunoLevy opened this issue Feb 9, 2025 · 0 comments
Closed
8 tasks done

Large .geogram files #223

BrunoLevy opened this issue Feb 9, 2025 · 0 comments

Comments

@BrunoLevy
Copy link
Owner

BrunoLevy commented Feb 9, 2025

  • FIXED cannot write a .geogram file if one of the arrays is larger than 4 Gb
    • Linux
    • Mac
    • Windows
  • Write a small test program and test it on the three platforms
  • distinguish and handle properly .geogram files written in GARGANTUA and in standard mode
  • optimize (for now, converts each read index_t one by one ...), and aways store arrays in 32 bits if they fit.
  • we may have a problem with NO_INDEX that has a different representation in GARGANTUA and in standard mode

Changes summary:

In geogram/third_party/zlib/zconf.h

#if defined(__APPLE__) || defined(_WIN32) || defined(_WIN64)
#define _LARGEFILE64_SOURCE 1
#define _LFS64_LARGEFILE 1
#define _FILE_OFFSET_BITS 64
#endif
  • On MacOS, got z_off64_t (and off64_t) undefined type name -> under MacOS, file IO is always 64 bits, #define off64_t off_t and #define lseek64 lseek.
  • On Windows, in geofile.cpp, missing type specifier (does not know ssize_t it seems) -> seems to be OK when I defined it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant