tried to fix few things #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2018 23:17
the filter method here does not serve any purpose.
removed the unused property grammar
the if statement is never accessed since all symbols are nonTerminals, so the condition cannot be true.
the firstSet object is already created for all Terminals and nonTerminals:
prod.derivation.forEach(function(d) {
if (d === '') {
return;
}
else if (that.isNonTerminal(d){
that.firstSet[d] = {};
that.followSet[d] = {};
}
else {
that.firstSet[d] = {};
that.firstSet[d][d] = 1;
}
});
|
Hey, thanks for contributing! unfortunately I have been really busy lately and still didn't get time to look at your changes ;( probably next week I will have some free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi!
I didn't really fix anything, your package is still working just as perfectly.
I used your code as a way to learn object-oriented javascript, and along the way, I found few things that your code can look better without.