Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHP 7.3 #35

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Run tests on PHP 7.3 #35

merged 1 commit into from
Jan 6, 2019

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Jan 5, 2019

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 436e716 on ntzm:patch-1 into 66370b0 on Brunty:master.

@WyriHaximus WyriHaximus requested a review from Brunty January 5, 2019 13:29
WyriHaximus
WyriHaximus approved these changes Jan 5, 2019
View reviewed changes
Copy link
Collaborator

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Brunty
Copy link
Owner

Brunty commented Jan 6, 2019

LGTM 👍

Thanks for this @ntzm 😄

@Brunty Brunty merged commit 06db910 into Brunty:master Jan 6, 2019
@ntzm ntzm deleted the patch-1 branch January 6, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brunty Brunty Brunty approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ntzm @coveralls @Brunty @WyriHaximus