Fixes from PR code review #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
|
@BryanCutler there are some API changes in pyarrow, I'm writing a patch now to fix |
Owner
Author
|
Ok thanks, I'll make sure to get that updated in the PR also |
|
Just waiting on Spark to compile to check that things still work =S |
BryanCutler
added a commit
that referenced
this pull request
Jan 31, 2017
defined ArrowPayload and encapsulated Arrow classes in ArrowConverters addressed some minor comments in code review closes #21
BryanCutler
added a commit
that referenced
this pull request
Feb 23, 2017
defined ArrowPayload and encapsulated Arrow classes in ArrowConverters addressed some minor comments in code review closes #21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed some feedback from the PR. I'll merge these changes unless there are comments, cc @wesm @icexelloss