Skip to content

Commit

Permalink
There has been an issue with open source contributors being able to p…
Browse files Browse the repository at this point in the history
…erform CI runs for their PRs - this is related to the addition of the pro checkout/submodule recursion in a recent update. Changing it to not use the contributors personal access token, but to instead use the github access token so that it can always be checked out and tested again the specified pro version.
  • Loading branch information
mike12345567 committed Jun 1, 2023
1 parent d07a177 commit 6eb9228
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions .github/workflows/budibase_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ on:
env:
BRANCH: ${{ github.event.pull_request.head.ref }}
BASE_BRANCH: ${{ github.event.pull_request.base.ref}}
PERSONAL_ACCESS_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}

jobs:
lint:
Expand All @@ -37,7 +36,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
Expand All @@ -55,7 +54,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
Expand All @@ -75,7 +74,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
Expand All @@ -95,7 +94,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
Expand All @@ -110,7 +109,7 @@ jobs:
- uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
- name: Use Node.js 14.x
uses: actions/setup-node@v3
with:
Expand All @@ -134,7 +133,7 @@ jobs:
uses: actions/checkout@v3
with:
submodules: true
token: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
token: ${{ secrets.GITHUB_TOKEN }}
fetch-depth: 0
- name: Check submodule
run: |
Expand Down

0 comments on commit 6eb9228

Please sign in to comment.