Form Fields no longer work as data provider bindings

[Gomeyy]

Describe the bug
I can no longer use a form field as a data provider binding after updating to 1.0.44, they also don't show up as options when using handlebars when setting a binding.

To Reproduce
Steps to reproduce the behavior:

1. Create a form with any field
2. Create a data provider in that form
3. Try to use that field as a binding in the data provider

Expected behavior
Being able to use form variables in data provider bindings

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browser Chrome
• Version 97.0.4692.71

Additional context
Add any other context about the problem here.

[mike12345567]

Hi @Gomeyy - just to confirm, by using a field as a binding a data provider, how are you using it? Are you using it as a defined filter? I've just tried this on 1.0.44 and didn't have any issues - trying to work out the reproduction steps.

[Gomeyy]

@mike12345567 Using a form field as a query binding not a filter

This is what I see when using a data provider, no bindable values

When using a headline at the same position in the hierarchy is acts as I would expect

[mike12345567]

Thanks @Gomeyy for the further information - I can see that happening as well - will get a fix out for it.

[mike12345567]

Hi @Gomeyy - I've triggered v1.0.45 to release which should resolve your issue.

@sergey-dme - if possible could you check if it resolves your issue as well? If not it'd be good to try and diagnose what went wrong in your app too.

Latest release: https://github.com/Budibase/budibase/releases/tag/v1.0.45

[Gomeyy]

@mike12345567 Okay, so the bindable values are appearing now for data providers.

But now when running a rest query on the design tab any bindings assigned for that rest query become empty?

I have a company binding on one of my rest queries and when I run it from the data tab, it uses the default value and runs fine.

When I run the same query from a data provider/table block it doesn't use the default value, or any value I attempt to assign and seems to be running the query with that binding as an empty string.

[mike12345567]

Hi @Gomeyy - i've been trying to re-create to not much success, can you try a few things for me:

1. If you create a new app, add a REST datasource and then try it does the same problem occur?
2. Just to check, have you updated your app client library version? You'll see a little blue refresh icon in the top right if you haven't.
   

[Gomeyy]

@mike12345567 Okay, so it seemed to be the second one, I had the blue refresh icon. Clicking that and updating to 1.0.45 fixed the previous issue but upon updating, assigning a data provider as the data value of another data provider causes it to perpetually load

Edit:
Saw this #4069 just now and it was apparently fixed?

[aptkingston]

@Gomeyy my PR (#4086) to fix that issue (#4069) was just merged half an hour ago, but to our develop branch, so it won't be shipped until our next release which should be about 10 days away.

[Gomeyy]

@aptkingston Great! Sorry I missed the develop branch, thanks for the info.

[aptkingston]

No worries! We've actually decided to pull this fix into master as part of this PR (#4134), so we'll actually get it live very soon 👍