Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore - Pipeline npm version updates #10360

Merged
merged 77 commits into from
May 4, 2023
Merged

Chore - Pipeline npm version updates #10360

merged 77 commits into from
May 4, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Apr 20, 2023 •
edited
Loading

Description

Changing pipelines to allow "npm-less" builds. After this PR, the pipeline flow will be the following:

  1. On develop/master push, tag it as vX.Y.Z-alpha.R and vX.Y.Z respectively
  2. Change the develop/master release pipeline to trigger on tag created instead of running on every commit
  3. Change the develop/master release pipeline to use the version on the tag as dependencies, to publish the npm and to build the docker images. This action does not pushes any git changes anymore
  4. Changing all the committed versions as 0.0.1. On the local development time lerna workspaces will take care of the links, at pipeline time the modified actions will
  5. Add some scripts to handle the dev process, depending on the access rights to local pro

Why these changes:

  1. Using yarn workspaces we don't need to keep tracking the versions in the code. Constantly updating these versions keep causing conflicts between develop and master, making almost impossible adding extra environments
  2. Not having a tag and release as a single action will allow us to break down the pipeline steps, easily rolling back to a specific version without rebumping
  3. Not having the package versions will prevent any race conditions between builds and bumps, specially around pro

@github-actions
Copy link
Contributor

github-actions bot commented Apr 20, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@adrinr adrinr force-pushed the chore/pipeline_npm_version_updates branch 2 times, most recently from 6494a35 to 8a5b9af Compare April 20, 2023 18:34
@adrinr adrinr changed the base branch from develop to chore/pro_as_submodule April 20, 2023 18:36
@adrinr adrinr force-pushed the chore/pro_as_submodule branch from 8d05c09 to 05579e6 Compare April 20, 2023 18:48
@adrinr adrinr force-pushed the chore/pipeline_npm_version_updates branch 7 times, most recently from c92082b to 3ab9da3 Compare April 21, 2023 09:23
Base automatically changed from chore/pro_as_submodule to chore/npmless-builds April 24, 2023 12:26
@adrinr adrinr marked this pull request as ready for review April 24, 2023 18:38
@adrinr adrinr force-pushed the chore/pipeline_npm_version_updates branch from 661d507 to 9b760d9 Compare April 24, 2023 19:02
@adrinr adrinr changed the title Chore/pipeline npm version updates Chore - Pipeline npm version updates Apr 24, 2023
mike12345567
mike12345567 approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! So nice to see all those 0.0.1!

adrinr added 2 commits May 4, 2023 10:27
@adrinr
Update pro ref
d84d403
@adrinr
Merge branch 'chore/npmless-builds' into chore/pipeline_npm_version_u…
d55a383 
…pdates

# Conflicts:
#	packages/backend-core/package.json
#	packages/bbui/package.json
#	packages/builder/package.json
#	packages/cli/package.json
#	packages/client/package.json
#	packages/frontend-core/package.json
#	packages/sdk/package.json
#	packages/server/package.json
#	packages/shared-core/package.json
#	packages/string-templates/package.json
#	packages/types/package.json
#	packages/worker/package.json
#	yarn.lock
@adrinr adrinr merged commit 54f5c0b into chore/npmless-builds May 4, 2023
@adrinr adrinr deleted the chore/pipeline_npm_version_updates branch May 4, 2023 09:30
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

@Rory-Powell Rory-Powell Awaiting requested review from Rory-Powell

@shogunpurple shogunpurple Awaiting requested review from shogunpurple

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinr @mike12345567