Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow empty group names on builder #10512

Merged
merged 4 commits into from
May 10, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 8, 2023

Description

Check user group creation/edition to not allow empty or whitespace names, both in the API or in the builder

Addresses:

Screenshots

image

@codecov-commenter
Copy link

Codecov Report

Merging #10512 (e399f16) into develop (1c203a3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e399f16 differs from pull request most recent head f51f00b. Consider uploading reports for the commit f51f00b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop   #10512   +/-   ##
========================================
  Coverage    69.71%   69.71%           
========================================
  Files          536      536           
  Lines        19515    19515           
  Branches      3884     3885    +1     
========================================
  Hits         13605    13605           
  Misses        5467     5467           
  Partials       443      443           
Impacted Files Coverage Δ
packages/worker/src/tests/api/groups.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr merged commit 77ed588 into develop May 10, 2023
@adrinr adrinr deleted the budi-6158/handle_empty_group_names branch May 10, 2023 08:23
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants