Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/qa 22 improve qa core boilerplate #10539

Merged
merged 8 commits into from
May 22, 2023

Conversation

Pedro-Revez-Silva
Copy link

@Pedro-Revez-Silva Pedro-Revez-Silva commented May 10, 2023

Description

Some code in the internal API classes is repeated, this PR aims to remove as much as possible into a BaseAPI class that can be extended.

Addresses:

Note:
There were some tests broken before this PR and there are some tests that seem flaky after I applied these changes. The error message is not very clear on what the problem is so I will fix the tests in another.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #10539 (d609b63) into develop (fbb23a4) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d609b63 differs from pull request most recent head aaee3cf. Consider uploading reports for the commit aaee3cf to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop   #10539      +/-   ##
===========================================
+ Coverage    69.48%   69.50%   +0.02%     
===========================================
  Files          536      536              
  Lines        19737    19691      -46     
  Branches      3914     3904      -10     
===========================================
- Hits         13714    13687      -27     
+ Misses        5583     5565      -18     
+ Partials       440      439       -1     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Pedro-Revez-Silva Pedro-Revez-Silva marked this pull request as ready for review May 17, 2023 20:34
@Pedro-Revez-Silva Pedro-Revez-Silva merged commit ceebf08 into develop May 22, 2023
@Pedro-Revez-Silva Pedro-Revez-Silva deleted the tests/qa-22-improve-qa-core-boilerplate branch May 22, 2023 11:48
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants