Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PG connection verification #10545

Merged
merged 13 commits into from
May 15, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 11, 2023

Description

Implementing Postgres connection checks:

  1. Typing datasources
  2. Setting up connection tests in the interfaces
  3. Implementing the connections tests for PG
  4. Testing use cases

Addresses:

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Merging #10545 (760d069) into feature/datasource-conns (12b06c8) will decrease coverage by 0.02%.
The diff coverage is 68.18%.

❗ Current head 760d069 differs from pull request most recent head d0a75a8. Consider uploading reports for the commit d0a75a8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                     Coverage Diff                      @@
##           feature/datasource-conns   #10545      +/-   ##
============================================================
- Coverage                     69.89%   69.87%   -0.02%     
============================================================
  Files                           536      536              
  Lines                         19545    19552       +7     
  Branches                       3893     3893              
============================================================
+ Hits                          13661    13662       +1     
- Misses                         5449     5455       +6     
  Partials                        435      435              
Impacted Files Coverage Δ
...r/src/migrations/functions/backfill/app/queries.ts 78.94% <ø> (-1.06%) ⬇️
packages/server/src/integrations/postgres.ts 55.14% <33.33%> (-2.55%) ⬇️
packages/server/src/integrations/index.ts 76.66% <88.88%> (+0.80%) ⬆️
packages/server/src/api/controllers/integration.ts 100.00% <100.00%> (ø)
...ages/server/src/sdk/app/datasources/datasources.ts 76.08% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr changed the title Implement pg connection verification Implement PG connection verification May 15, 2023
@adrinr adrinr changed the base branch from develop to feature/datasource-conns May 15, 2023 11:16
@adrinr adrinr force-pushed the budi-6932/verify_pg_connection branch from 760d069 to 2b4643d Compare May 15, 2023 11:17
@adrinr adrinr marked this pull request as ready for review May 15, 2023 11:17
@adrinr adrinr requested a review from mike12345567 May 15, 2023 11:26
@mike12345567 mike12345567 merged commit 3ec10e5 into feature/datasource-conns May 15, 2023
@mike12345567 mike12345567 deleted the budi-6932/verify_pg_connection branch May 15, 2023 13:09
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants