Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant yarn setup on pro bootstrap #10560

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

Rory-Powell
Copy link
Contributor

Description

Removing the yarn setup in the bootstrap.sh script. the script will already run

  • yarn
  • lerna bootstrap

The setup subsequently runs:

  • yarn && yarn bootstrap && yarn build

The only extra step here being the build, which shouldn't be necessary at this point

Addresses:

  • no ticket

@Rory-Powell Rory-Powell requested a review from adrinr May 12, 2023 10:41
@codecov-commenter
Copy link

Codecov Report

Merging #10560 (9768282) into develop (59b81d1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##           develop   #10560   +/-   ##
========================================
  Coverage    69.88%   69.88%           
========================================
  Files          536      536           
  Lines        19537    19537           
  Branches      3893     3893           
========================================
  Hits         13653    13653           
  Misses        5449     5449           
  Partials       435      435           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adrinr adrinr merged commit 4a43af7 into develop May 24, 2023
@adrinr adrinr deleted the chore/remove-extra-setup branch May 24, 2023 11:31
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants