Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify google sheets connection #10601

Merged
merged 12 commits into from
May 16, 2023
Merged

Verify google sheets connection #10601

merged 12 commits into from
May 16, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 16, 2023

Description

Implement google sheets datasource verification

@adrinr adrinr requested a review from mike12345567 May 16, 2023 08:03
@adrinr adrinr force-pushed the budi-6932/verify_google_sheets branch from 6cd2b7e to 0275ef0 Compare May 16, 2023 09:45
mike12345567
mike12345567 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - forgot we would need to retrieve the config for verification of GSheets!

@adrinr adrinr merged commit f305c91 into feature/datasource-conns May 16, 2023
@adrinr adrinr deleted the budi-6932/verify_google_sheets branch May 16, 2023 11:33
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinr @mike12345567