Revert flatpickr version to fix bug in 3.3.2 #10612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #10612 +/- ##
===========================================
+ Coverage 69.88% 69.98% +0.09%
===========================================
Files 536 536
Lines 19537 19562 +25
Branches 3893 3896 +3
===========================================
+ Hits 13653 13690 +37
+ Misses 5449 5439 -10
+ Partials 435 433 -2 see 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in svelte-flatpickr v3.3.2 in which time-only dates throw errors. Reverting to v3.2.3 fixes this issue.
I've also improved the display of time-only fields inside the Grid, as previously they could flash "Invalid date" due to the inconsistent nature of the value prop that flatpickr uses.
This is being merged to develop rather than master because develop already contains further changes to these same fields and I'd prefer to avoid the conflicts. This is a nasty enough issue but is hopefully rare enough that is not affecting many users, so delaying release slightly should be ok.
Addresses: