Automation logging updates #10626
Merged
Automation logging updates #10626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvcalderon
reviewed
May 17, 2023
Rory-Powell
commented
May 17, 2023
| // An error occurred. | ||
| console.error(...getLogParams(eventType, BullEvent.ERROR, { error })) | ||
| }) | ||
|
|
||
| if (process.env.NODE_DEBUG?.includes("bull")) { |
There was a problem hiding this comment.
I'm planning on turning off bull debug logging by default (after investigation) to bring down logging costs, hence the stalled and error logs above being promoted to logging by default
mike12345567
approved these changes
May 17, 2023
adrinr
reviewed
May 17, 2023
| @@ -104,6 +104,22 @@ async function newContext(updates: ContextMap, task: any) { | |||
| return Context.run(context, task) | |||
| } | |||
|
|
|||
| export async function doInAutomationContext( | |||
| appId: string, | |||
There was a problem hiding this comment.
Can we use an object as a parameter to make it more verbose in its usage?
export async function doInAutomationContext(params: {
appId: string,
automationId: string,
task: any
})
+1 to this, some of the stuff you've done around the triggers and automation thread code overlap quite heavily with some work I was doing for sync automations. LGTM though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to logging for better pino integration to aid debugging via datadog.
Additionally add some better type definitions around bull jobs specific to automations.