Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch table names from google datasource #10663

Merged
merged 5 commits into from
May 23, 2023
Merged

Fetch table names from google datasource #10663

merged 5 commits into from
May 23, 2023

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented May 23, 2023

@adrinr adrinr requested a review from mike12345567 May 23, 2023 07:57
adrinr
adrinr commented May 23, 2023
View reviewed changes
packages/server/src/integrations/googlesheets.ts
@@ -148,7 +148,6 @@ class GoogleSheetsIntegration implements DatasourcePlus {
async testConnection(): Promise<ConnectionInfo> {
try {
await this.connect()
await this.client.loadInfo()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done internally on the test connection

@adrinr adrinr merged commit f206b0e into feature/table-fetching May 23, 2023
@adrinr adrinr deleted the budi-6944-google-sheets-fetch-all-worksheets-when branch May 23, 2023 08:30
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrinr @mike12345567