Chore - Respect esbuild config paths #10694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
commented
May 25, 2023
packages/server/tsconfig.build.json
Outdated
| @@ -8,7 +8,7 @@ | |||
| "esModuleInterop": true, | |||
There was a problem hiding this comment.
These tsconfig.json are not really related to the issue, I just tidied them up while analysing the issue
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #10694 +/- ##
========================================
Coverage 69.34% 69.34%
========================================
Files 536 536
Lines 19605 19605
Branches 3918 3918
========================================
Hits 13595 13595
Misses 5574 5574
Partials 436 436 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mike12345567
approved these changes
May 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found an issue that if a package (lets say
backend-core) was built, when building the server via esbuild, that dist folder was used instead of using the tsconfig.paths defined. This broke our dev experience.This PR is solving this by using the
tsconfig-pathsesbuild plugin