Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and updates for export internal rows #10702

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

deanhannigan
Copy link
Contributor

Description

  • Export rows fixed for internal datasources. The call to exports.search during export was causing the export to fail.
  • Updates to the UI with appropriate failure/success messaging to better inform the user.

Addresses:

  • BUDI-7059

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@codecov-commenter
Copy link

Codecov Report

Merging #10702 (f4b5a9d) into develop (504a08f) will not change coverage.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##           develop   #10702   +/-   ##
========================================
  Coverage    69.37%   69.37%           
========================================
  Files          537      537           
  Lines        19626    19626           
  Branches      3921     3921           
========================================
  Hits         13616    13616           
  Misses        5574     5574           
  Partials       436      436           
Impacted Files Coverage Δ
...ackages/server/src/api/controllers/row/internal.ts 81.42% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deanhannigan deanhannigan merged commit b6a5f4e into develop May 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants