Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Bindings V2 #10759

Merged
merged 9 commits into from
Jun 2, 2023
Merged

Fixes for Bindings V2 #10759

merged 9 commits into from
Jun 2, 2023

Conversation

deanhannigan
Copy link
Contributor

Description

  • Updated the headless binding drawer height to accommodate being displayed on top of other builder drawers.
  • Added appropriate labelling for the actions/event bindings in the builder.

@deanhannigan deanhannigan requested a review from aptkingston June 1, 2023 10:50
@deanhannigan deanhannigan marked this pull request as draft June 1, 2023 10:57
@deanhannigan deanhannigan changed the title Fixes for Vindings V2 Fixes for Bindings V2 Jun 1, 2023
@deanhannigan deanhannigan marked this pull request as ready for review June 1, 2023 15:35
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2023 •
edited
Loading

Codecov Report

Merging #10759 (16ee3af) into develop (35919ae) will decrease coverage by 19.00%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##           develop   #10759       +/-   ##
============================================
- Coverage    68.97%   49.98%   -19.00%     
============================================
  Files          540      153      -387     
  Lines        19912     5162    -14750     
  Branches      3966     1033     -2933     
============================================
- Hits         13734     2580    -11154     
+ Misses        5737     2364     -3373     
+ Partials       441      218      -223

see 388 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shogunpurple
shogunpurple approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deanhannigan deanhannigan merged commit 46cbe80 into develop Jun 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shogunpurple shogunpurple shogunpurple approved these changes

@aptkingston aptkingston aptkingston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deanhannigan @codecov-commenter @aptkingston @shogunpurple