Fix/logo urls #10790
Merged
Fix/logo urls #10790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## develop #10790 +/- ##
========================================
Coverage 49.98% 49.98%
========================================
Files 153 153
Lines 5164 5164
Branches 1033 1033
========================================
Hits 2581 2581
Misses 2365 2365
Partials 218 218 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Rory-Powell
reviewed
Jun 5, 2023
| @@ -352,6 +360,15 @@ export async function publicSettings( | |||
| config: { | |||
| ...config, | |||
| ...branding, | |||
| ...(branding.faviconUrl && branding.faviconUrl !== "" | |||
There was a problem hiding this comment.
Can we extract this to a variable? I think it's a bit hard to read inline
Rory-Powell
approved these changes
Jun 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and refactoring for the Logo Url and Favicon Url branding configuration options.
Addresses: