Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support views on plus datasources #11615

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Aug 29, 2023

Description

Fixing view backend to support plus datasources. Datasource plus tables are stored in the ds document instead of a separate the table doc, so we need to update the documents accordingly

@adrinr adrinr requested a review from aptkingston August 29, 2023 15:43
@nx-cloud
Copy link

nx-cloud bot commented Aug 29, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 95d2926. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

Codecov Report

Merging #11615 (95d2926) into views-v2-frontend (f521179) will increase coverage by 27.29%.
Report is 4 commits behind head on views-v2-frontend.
The diff coverage is 94.73%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                  Coverage Diff                   @@
##           views-v2-frontend   #11615       +/-   ##
======================================================
+ Coverage              46.45%   73.74%   +27.29%     
======================================================
  Files                    164      321      +157     
  Lines                   5741    13488     +7747     
  Branches                1156     2804     +1648     
======================================================
+ Hits                    2667     9947     +7280     
- Misses                  2812     3309      +497     
+ Partials                 262      232       -30     
Files Changed Coverage Δ
packages/server/src/api/controllers/datasource.ts 56.48% <ø> (ø)
packages/server/src/sdk/app/views/internal.ts 93.61% <93.61%> (ø)
packages/server/src/sdk/app/views/external.ts 94.44% <94.44%> (ø)
packages/server/src/sdk/app/views/index.ts 100.00% <100.00%> (ø)

... and 481 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@shogunpurple shogunpurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr merged commit 8a7086d into views-v2-frontend Aug 29, 2023
@adrinr adrinr deleted the BUDI-7189/views_on_plus_ds branch August 29, 2023 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants