-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support views on plus datasources #11615
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 95d2926. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## views-v2-frontend #11615 +/- ##
======================================================
+ Coverage 46.45% 73.74% +27.29%
======================================================
Files 164 321 +157
Lines 5741 13488 +7747
Branches 1156 2804 +1648
======================================================
+ Hits 2667 9947 +7280
- Misses 2812 3309 +497
+ Partials 262 232 -30
... and 481 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fixing view backend to support plus datasources. Datasource plus tables are stored in the ds document instead of a separate the table doc, so we need to update the documents accordingly