File upload component for azure blob #12530
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the S3Upload component and action to be generic, supporting both S3 and Azure Blob Storage.
I was pleased that this didn't turn out to require as much effort as I feared because both work in a very similar way.
Unfortunately the refactor of the manifest to use a generic name and not specifically reference S3 causes backwards compatibility issues - you would need to re-add the file upload components, and re-configure the upload actions.
Is there a deprecation process I could follow for that?
Addresses
Screenshots
Adding the datasource
Connecting
List blobs (files)
Deleting '2302.gif' from the '01' directory
S3Upload component is now simply 'File Upload' component
Select an S3 or Azure Blob Storage datasource
Uploading:
https://github.com/Budibase/budibase/assets/101575380/fadb58c1-5eb4-4780-aedf-f9d93823c3aa