Update view handling of filters #14614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aptkingston
commented
Sep 20, 2024
| } | ||
| // Join them together if both | ||
| allFilters.groups = [...allFilters.groups, ...$filter.groups] | ||
| return allFilters |
There was a problem hiding this comment.
Just rewrote this to be more explicit and construct the minimal complexity of query possible.
| @@ -365,7 +364,9 @@ export default class DataFetch { | |||
| let refresh = false | |||
| const entries = Object.entries(newOptions || {}) | |||
| for (let [key, value] of entries) { | |||
| if (JSON.stringify(value) !== JSON.stringify(this.options[key])) { | |||
| const oldVal = this.options[key] == null ? null : this.options[key] | |||
| const newVal = value == null ? null : value | |||
There was a problem hiding this comment.
Added this in as undefined and null were treating as being different and therefore causing a fetch to refresh all data.
|
|
||
| if (!parsed?.groups?.length && definition.query?.groups?.length) { | ||
| this.options.filter = definition.query | ||
| } |
There was a problem hiding this comment.
We never want to set the filter to the query definition, as that is redundant and causes the filters to be sent up in the search request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates how views handle filters and when they're attached to requests. This fixes some pre-existing issues and some newly introduced ones, that resulted in things like double queries and attaching view filters in the search queries (which is unnecessary as they are saved into the view definition).