Fix table updates wiping out view calculation fields. #14756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
commented
Oct 10, 2024
Comment on lines
+34
to
+36
| if (!sdk.views.isV2(view) || helpers.views.isCalculationView(view)) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
This is the only meaningful change in here, but I did a little refactoring to reduce the nesting and make this more readable while I was here.
samwho
commented
Oct 10, 2024
Comment on lines
+99
to
+104
| if (!schema.field) { | ||
| throw new HTTPError( | ||
| `Calculation field "${name}" is missing a "field" property`, | ||
| 400 | ||
| ) | ||
| } |
There was a problem hiding this comment.
This a separate problem I ran into accidentally. It would error previously, but the message was unhelpful. This just improves the error message.
samwho
commented
Oct 10, 2024
Comment on lines
+381
to
+382
| const viewSchema = view.schema[fieldName] | ||
| if (!helpers.views.isCalculationField(viewSchema) && !schema[fieldName]) { |
There was a problem hiding this comment.
This is the primary fix for the problem this PR addresses.
mike12345567
approved these changes
Oct 10, 2024
adrinr
approved these changes
Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes another problem @aptkingston ran into: when updating a table, all of the view schemas are synced with the table. This would remove any field in the view not found in the table schema. I've added a check for calculation fields in there.