Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view join parser for non-array values any "many" types #14790

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

aptkingston
Copy link
Member

Description

Fixes a crash when viewing certain types of view join columns with non-array values.

Addresses

@aptkingston aptkingston marked this pull request as ready for review October 14, 2024 11:22
Copy link

qa-wolf bot commented Oct 14, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@aptkingston aptkingston requested a review from adrinr October 14, 2024 12:12
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥖

@aptkingston aptkingston merged commit 2b9ca50 into v3-ui Oct 14, 2024
11 checks passed
@aptkingston aptkingston deleted the fix-view-join-parser branch October 14, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants