-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-inheritance RBAC (backend) #14816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt - using role test API to make this a bit easier to adjust going forward.
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
…le-multi-inheritance
… into feature/role-multi-inheritance
… detected correctly.
…le-multi-inheritance
…le-multi-inheritance
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
reviewed
Oct 17, 2024
samwho
reviewed
Oct 17, 2024
samwho
approved these changes
Oct 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As required for the new RBAC experience roles need a way to reference multiple other roles, meaning that more complex flows of roles can be created.
The main difference within this is the
inherits
type of a role can bestring | string[]
- the string format will apply to old roles and built-ins, while the array will be used for new roles to reference a set of roles below them.With this, there is a high chance of role loops (this was possible previously as you could set two roles to inherit each other, however this would be un-unusable since it doesn't reference any built in (so essentially two public roles). The API has been updated to protect against loops, as well as providing a function in
shared-core
that can check for loops given a list of roles.A general pass around prefixing has been performed, making sure that roles always take their external format when returned from the API as well as storing the roles with their complete prefixed format in the DB.
Finally, a few new test cases have been added:
accessible
endpoint which lists the roles a user has access to, making sure this works with multi-inheritance.routing.roleId
are returned.