Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SQS flag #14835

Merged
merged 29 commits into from
Nov 18, 2024
Merged

Remove SQS flag #14835

merged 29 commits into from
Nov 18, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 21, 2024

Description

Remove SQS flag and lucene branches. This has been shipped for a while and some newer features require SQS enabled, so we cannot run BB without it anymore. Cleaning code and simplifying tests.

Related:

Copy link

qa-wolf bot commented Oct 21, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@adrinr adrinr force-pushed the chore/sqs-always-on branch from c3bbdb4 to b15b0fb Compare October 21, 2024 13:23
@adrinr adrinr closed this Oct 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
@adrinr adrinr reopened this Nov 4, 2024
@adrinr adrinr changed the title Chore/sqs always on Remove SQS flag Nov 4, 2024
@adrinr adrinr marked this pull request as ready for review November 7, 2024 12:21
@adrinr adrinr requested a review from a team as a code owner November 7, 2024 12:21
@adrinr adrinr requested review from samwho and mike12345567 and removed request for a team November 7, 2024 12:21
@adrinr adrinr enabled auto-merge November 18, 2024 09:35
@adrinr adrinr merged commit 36f93dd into master Nov 18, 2024
13 checks passed
@adrinr adrinr deleted the chore/sqs-always-on branch November 18, 2024 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants