-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SQS flag #14835
Merged
Merged
Remove SQS flag #14835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
github-actions
bot
added
firestorm
Data/Infra/Revenue Team
size/m
size/xl
and removed
size/m
labels
Oct 21, 2024
adrinr
force-pushed
the
chore/sqs-always-on
branch
from
October 21, 2024 11:35
89478cd
to
260dcad
Compare
adrinr
force-pushed
the
chore/sqs-always-on
branch
from
October 21, 2024 13:23
c3bbdb4
to
b15b0fb
Compare
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
November 7, 2024 12:21
samwho
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove SQS flag and lucene branches. This has been shipped for a while and some newer features require SQS enabled, so we cannot run BB without it anymore. Cleaning code and simplifying tests.
Related: