Frontend updates for storing view filters in queryUI
#14857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with nullish values
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
aptkingston
requested review from
mike12345567
and removed request for
a team
samwho
reviewed
Oct 24, 2024
Comment on lines
+57
to
+59
| // We still may need to migrate this even though the backend does it automatically now | ||
| // for query definitions. This is because we might be editing saved filter definitions | ||
| // from old screens, which will still be of type LegacyFilter[]. |
samwho
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the stored location of view filters to match recent backend work.