Missing old row on automations #14862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
commented
Oct 24, 2024
| @@ -54,7 +66,9 @@ class AutomationEmitter { | |||
| appId, | |||
| row, | |||
| table, | |||
| oldRow, | |||
There was a problem hiding this comment.
This is the actual fix
adrinr
changed the title
PClmnt
reviewed
Oct 24, 2024
| @@ -49,3 +60,32 @@ export interface UserCtx<RequestBody = any, ResponseBody = any> | |||
| export interface BBContext extends Ctx { | |||
| user?: ContextUser | |||
| } | |||
|
|
|||
| export interface ContextEmitter { | |||
There was a problem hiding this comment.
This is really nice, I was actually confused about this the other day when trying to track down some emitter issues - the fact we had the AutomationEmitter and the standard emitter etc. Really nice stuff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had an issue where some chained automations were not passing the proper data, missing some data such as "oldRow". The problem was that it was not properly sent, and while debugging the issue I realised that there is not much typing around automation emitters.
This PR is mainly typing everything around emitters to stop using magic strings, parameters and
anys. It also fixes the actual issue, passing theoldRowaccordingly.