Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple relationships same tables #14877

Merged
merged 16 commits into from
Oct 28, 2024
Merged

Support multiple relationships same tables #14877

merged 16 commits into from
Oct 28, 2024

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Oct 25, 2024 •
edited
Loading

Description

Fixing a couple of issues related to relationships:

  1. Fixing deleting entries with many-to-many linked data
  2. Fixing updates with multiple many-to-many between the same tables

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Oct 25, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Oct 25, 2024
@adrinr adrinr changed the title Fix/support multiple relationships same tables Support multiple relationships same tables Oct 25, 2024
@adrinr adrinr marked this pull request as ready for review October 25, 2024 15:02
@adrinr adrinr requested a review from a team as a code owner October 25, 2024 15:02
@adrinr adrinr requested review from samwho and removed request for a team October 25, 2024 15:02
@adrinr adrinr requested a review from mike12345567 October 25, 2024 15:02
mike12345567
mike12345567 reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one question around this - should we merge this to master - or should it go to v3-ui as this is a feature/enhancement?

Also - we will need to remove the checks from the frontend which disable this.

@adrinr adrinr enabled auto-merge October 28, 2024 13:36
@adrinr adrinr merged commit b2f3e4f into master Oct 28, 2024
12 checks passed
@adrinr adrinr deleted the fix/support-multiple-relationships-same-tables branch October 28, 2024 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

@samwho samwho samwho approved these changes

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrinr @samwho @mike12345567