-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for logicalOperator inside UISearchFilter groups #14904
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for this? 🙏 There's a big group of them in viewV2.spec.ts
around line 4059.
I looked for tests inside shared-core where this resides and there were none, but looks like that's because the tests for it live elsewhere! Will do - I was going to if I had found them. |
Yeah, sorry about that. I didn't want to make assertions on the output of |
Description
Fixes an issue where logical operators inside groups in frontend filter structures were ignored when converting to a query.
Given a sample frontend filter group (
SearchFilterGroup
) of:Notice the
any
value forlogicalOperator
, meaning perform an "or".This was previously converted into:
Notice the
$and
operator which is incorrect.With this PR it is now correctly converted into:
This is safe to go to
v3-ui
rather than master as these structures do not exist in master yet.