fix for conditional automation step options always showing #14968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
andz-bb
commented
Nov 5, 2024
| @@ -865,7 +865,7 @@ | |||
| <!-- Custom Layouts --> | |||
| {#if stepLayouts[block.stepId]} | |||
| {#each Object.keys(stepLayouts[block.stepId] || {}) as key} | |||
| {#if canShowField(key, stepLayouts[block.stepId].schema)} | |||
| {#if canShowField(stepLayouts[block.stepId].schema)} | |||
There was a problem hiding this comment.
function canShowField(value) {
const dependsOn = value?.dependsOn
return !dependsOn || !!inputData[dependsOn]
}this function used to have key and value parameters but key was removed, meaning all cases where this was being called with two arguments were broken
…ons-always-rendering-send
…ons-always-rendering-send
…ndering-send' of github.com:Budibase/budibase into budi-8820-conditional-automation-step-options-always-rendering-send
andz-bb
deleted the
budi-8820-conditional-automation-step-options-always-rendering-send
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automation step options that should conditionally render based on other settings are currently always showing. I think the only place this is used is the send email automation step where calendar invite options should be shown only when Add calendar invite is checked.
Addresses
BUDI-8820
Screenshots
before
after
Launchcontrol
fix for send email automation step settings