BUDI-8831 gives users options to resize the logo #15045
Draft
+103
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion #14996 requested (among other things) the ability to resize the logo. In their case, the default 36px wasn't big enough.
Addresses
App Export
Screenshots
Resizing using the basic dropdown, or manually inputting a value
https://jam.dev/c/7f057573-a76d-40dc-ad19-e2d197ae8f8e
Resizing according to bindings like device
http://localhost:10000/builder/app/app_dev_d6c85f662cbb40fd8b38ab14b508446c/design/screen_a35a4cf95b574a48b78d866fecaf2477/screen_a35a4cf95b574a48b78d866fecaf2477-navigation
Launchcontrol
Add a small description in layman's terms of what this PR achieves. This will be used in the release notes.